let dinifile.readFromEnv()'s environment parameter be const

[Herringway]

More const is nice, yes?

[dlang-bot]

Thanks for your pull request and interest in making D better, @Herringway! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#9618"

[RazvanN7]

Buildkite failure is unrelated.

[wilzbach]

CC @CyberShadow. Did you change anything in are recently? It's failing now on Buildkite due to a missing file.

[CyberShadow]

Did you change anything in are recently?

Yes, I did. I changed the structure of dub.sdl and updated .travis.yml too. But, the tests pass on my machine and on Travis. It seems to be a problem with the script running the tests on BuildKite - maybe it doesn't know how to test subpackages?

[CyberShadow]

The problem is here:

https://github.com/dlang/ci/blob/e0bbafa69d3fdc662a6f1a582f751124fbd421e6/buildkite/build_project.sh#L232-L233

[CyberShadow]

I already excluded the previous Jenkins-based project tester by checking the environment:

https://github.com/cybershadow/ae/blob/f449f54293a6fe73e7d16b44c61069cdbf02d3b2/sys/net/test.d#L76-L79

I've updated it to check for BuildKite:

https://github.com/CyberShadow/ae/releases/tag/v0.0.2389

Hopefully that will work.

[Geod24]

Why was this cast removed ?