Skip to content

Cleanup utf in module#9729

Merged
WalterBright merged 4 commits intodlang:masterfrom
benjones:cleanupUtfInModule
May 2, 2019
Merged

Cleanup utf in module#9729
WalterBright merged 4 commits intodlang:masterfrom
benjones:cleanupUtfInModule

Conversation

@benjones
Copy link
Contributor

Eliminate gotos in the UTF reencoding code (taking UTF16/32 files and encoding them as UTF 8). It also replaces pointer + length with slices during processing.

I think the new function I made should probably get pulled out and put with other UTF code, perhaps DRuntime?

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @benjones! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#9729"

Copy link
Member

@WalterBright WalterBright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments

@benjones benjones force-pushed the cleanupUtfInModule branch 4 times, most recently from 3bcaab3 to 7e837db Compare April 30, 2019 17:09
@benjones benjones force-pushed the cleanupUtfInModule branch from 7e837db to b65d1ee Compare May 1, 2019 04:52
@benjones benjones force-pushed the cleanupUtfInModule branch from b65d1ee to 7ac3004 Compare May 2, 2019 04:12
@thewilsonator
Copy link
Contributor

@WalterBright any more comments?

@thewilsonator thewilsonator requested a review from WalterBright May 2, 2019 16:05
@thewilsonator
Copy link
Contributor

@WalterBright all good now?

@WalterBright WalterBright merged commit 26b7c11 into dlang:master May 2, 2019
@benjones benjones deleted the cleanupUtfInModule branch May 3, 2019 04:28
@thewilsonator
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants