[stable] Fix some File-related issues surfacing with -lowmem#9771
Merged
dlang-bot merged 4 commits intodlang:stablefrom May 11, 2019
Merged
[stable] Fix some File-related issues surfacing with -lowmem#9771dlang-bot merged 4 commits intodlang:stablefrom
dlang-bot merged 4 commits intodlang:stablefrom
Conversation
As the dtor uses `mem.xfree()` to free the buffer, but read() has used malloc/realloc/free so far. This was only an issue with an enabled GC.
I guess that wasn't a real issue before -lowmem, as most File instances were living on the heap and NOT finalized at shutdown without enabled GC. Anyway, a File cannot mem.xfree() a backend buffer allocated with C malloc; fix it by NOT transferring the buffer ownership to the File and freeing the buffer immediately after writing the object file.
When writing it to file, the File took buffer ownership and freed the data immediately after writing it. Finalization of `*global.params.moduleDeps` with an enabled GC would have tried to free it again, as its buffer was still dangling.
kinke
requested review from
Geod24,
MartinNowak,
WalterBright and
rainers
as code owners
Contributor
|
Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "stable + dmd#9771" |
jacob-carlborg
approved these changes
May 11, 2019
thewilsonator
approved these changes
May 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[See the commit messages.]