Skip to content

document DMD style more prominently#9833

Merged
thewilsonator merged 1 commit intodlang:masterfrom
thewilsonator:dmdstyle
May 25, 2019
Merged

document DMD style more prominently#9833
thewilsonator merged 1 commit intodlang:masterfrom
thewilsonator:dmdstyle

Conversation

@thewilsonator
Copy link
Contributor

#9511 minus the controversial items.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#9833"

@thewilsonator thewilsonator added the Merge:72h no objection -> merge The PR will be merged if there are no objections raised. label May 22, 2019
@jacob-carlborg
Copy link
Contributor

Half of the tests don't pass 😢.

@thewilsonator
Copy link
Contributor Author

DAutoTest has a network problem, circle fails regularly for network and environmental reasons, semaphore fails because bootstrap with GDC8 got broken recently.

@thewilsonator thewilsonator added Merge:auto-merge and removed Merge:72h no objection -> merge The PR will be merged if there are no objections raised. labels May 25, 2019
@thewilsonator thewilsonator merged commit 544a6e4 into dlang:master May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants