Skip to content

remove unused imports from aggregate.d#9845

Merged
dlang-bot merged 1 commit intodlang:masterfrom
thewilsonator:agg-rm-import
May 23, 2019
Merged

remove unused imports from aggregate.d#9845
dlang-bot merged 1 commit intodlang:masterfrom
thewilsonator:agg-rm-import

Conversation

@thewilsonator
Copy link
Contributor

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#9845"

import dmd.semantic3;
import dmd.tokens;
import dmd.typesem;
import dmd.typesem : defaultInit;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is not the DMD style but that is the only function from there and I think it ought to be in mtype.d anyway, which I plan to follow up in another PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Walter approved selective top-level imports in the past. I think he just doesn't see much value in them, but from what I gathered he isn't against them. So imho it's more than fine if it's just a few symbols - especially if it's one or two.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'm trying to figure out which ones use a single import and mark them so.

With this one specifically I think it should be in mtype.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should invest time in doing this manually except when writing code which adds new imports. IIRC people have already written tools for this. I think @CyberShadow has one?

@dlang-bot dlang-bot merged commit 124b3a2 into dlang:master May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants