remove unused imports from aggregate.d#9845
Conversation
|
Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#9845" |
| import dmd.semantic3; | ||
| import dmd.tokens; | ||
| import dmd.typesem; | ||
| import dmd.typesem : defaultInit; |
There was a problem hiding this comment.
I know this is not the DMD style but that is the only function from there and I think it ought to be in mtype.d anyway, which I plan to follow up in another PR.
There was a problem hiding this comment.
Walter approved selective top-level imports in the past. I think he just doesn't see much value in them, but from what I gathered he isn't against them. So imho it's more than fine if it's just a few symbols - especially if it's one or two.
There was a problem hiding this comment.
Yeah I'm trying to figure out which ones use a single import and mark them so.
With this one specifically I think it should be in mtype.
There was a problem hiding this comment.
I don't think we should invest time in doing this manually except when writing code which adds new imports. IIRC people have already written tools for this. I think @CyberShadow has one?
bb65284 to
f79b17a
Compare
No description provided.