Skip to content

fix bad rendering of the changelog for the alias grammar changes#9847

Merged
dlang-bot merged 1 commit intomasterfrom
unknown repository
May 29, 2019
Merged

fix bad rendering of the changelog for the alias grammar changes#9847
dlang-bot merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented May 23, 2019

So the grammar block is not well rendered, I don't know why. Never mind, I remove it because the changelog has never exposed a $(GRAMMAR ) block to this date. Just a link will be fine for those who are interested.

@wilzbach, you still need to enable markdown preview when the change log is rendered. I tried to do it but the 1000 lines makefile of dlang.org repo causes me allergic reactions.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @Basile-z! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#9847"

@wilzbach
Copy link
Contributor

wilzbach commented May 23, 2019

@wilzbach, you still need to enable markdown preview when the change log is rendered.

IIRC @dgileadi was/is on this (enabling the markdown preview for dlang.org)

@thewilsonator thewilsonator added the Merge:72h no objection -> merge The PR will be merged if there are no objections raised. label May 27, 2019
@ghost
Copy link
Author

ghost commented May 29, 2019

@thewilsonator merge now ? Just rebased and squashed.

@thewilsonator thewilsonator added Merge:auto-merge and removed Merge:72h no objection -> merge The PR will be merged if there are no objections raised. labels May 29, 2019
@dlang-bot dlang-bot merged commit 3f67dc1 into dlang:master May 29, 2019
@ghost ghost deleted the patch-1 branch May 29, 2019 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants