Skip to content

Replace hilariously out of date backend architecture document#9850

Merged
dlang-bot merged 1 commit intodlang:masterfrom
thewilsonator:backend-docs
May 23, 2019
Merged

Replace hilariously out of date backend architecture document#9850
dlang-bot merged 1 commit intodlang:masterfrom
thewilsonator:backend-docs

Conversation

@thewilsonator
Copy link
Contributor

Also on that subject why do we have two AA implementations, another leaking allocator, that leaks from malloc instead of the GC?

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#9850"

@thewilsonator
Copy link
Contributor Author

@WalterBright can we:

  • rm backend/aarray.d and replace its uses with root/aav.d?
  • rm backend/outbuf.d and replace it with root/outbuffer?
  • rm backend/ph2.d and leak from just the GC?
  • mv complex.d root/complex.d && rm backend/bcomplex.d?

Copy link
Contributor

@jacob-carlborg jacob-carlborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacob-carlborg
Copy link
Contributor

I don’t think Walter want the backend to use the root package. Although I thought the reason for having the root package was for the frontend and backend to share code.

@thewilsonator
Copy link
Contributor Author

Ow, yeah that it a horrible rendering (looks much nicer in plain text, lol). Fixed.

@thewilsonator
Copy link
Contributor Author

Yes, a list looks much better.

@jacob-carlborg
Copy link
Contributor

jacob-carlborg commented May 23, 2019

Perhaps make the filenames bold as well. Or otherwise somehow separate the filename from the description.

@thewilsonator
Copy link
Contributor Author

Im about to go to sleep, don't let me stop you doing that ;)

@dlang-bot dlang-bot merged commit fa2414c into dlang:master May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants