Skip to content

Comments

Fix Issue 711 - combining mixins and overriding causes inifite loops#9908

Merged
dlang-bot merged 1 commit intodlang:masterfrom
RazvanN7:Issue_711
May 28, 2019
Merged

Fix Issue 711 - combining mixins and overriding causes inifite loops#9908
dlang-bot merged 1 commit intodlang:masterfrom
RazvanN7:Issue_711

Conversation

@RazvanN7
Copy link
Contributor

@RazvanN7 RazvanN7 commented May 28, 2019

No. 7 top oldest dmd bugs.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
711 normal combining mixins and overriding causes inifite loops

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#9908"

mixer.test();
}
mixin Mixer!() mixer;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the point of Bar and Bar2 to show that it doesn't matter if the mixin is placed before or after test?

Copy link
Contributor Author

@RazvanN7 RazvanN7 May 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Before this patch, if the mixin was before test it would have resulted in an infinite recursion at runtime. If the mixin would have been placed after test it would have resulted in an ICE at compile time.

@dlang-bot dlang-bot merged commit bd2cf9b into dlang:master May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants