Fix Issue 711 - combining mixins and overriding causes inifite loops#9908
Fix Issue 711 - combining mixins and overriding causes inifite loops#9908dlang-bot merged 1 commit intodlang:masterfrom
Conversation
|
Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#9908" |
| mixer.test(); | ||
| } | ||
| mixin Mixer!() mixer; | ||
| } |
There was a problem hiding this comment.
Is the point of Bar and Bar2 to show that it doesn't matter if the mixin is placed before or after test?
There was a problem hiding this comment.
Yes. Before this patch, if the mixin was before test it would have resulted in an infinite recursion at runtime. If the mixin would have been placed after test it would have resulted in an ICE at compile time.
No. 7 top oldest dmd bugs.