Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

core.stdc.fenv: Add platform-specific FE_XXX flags#1554

Merged
dlang-bot merged 1 commit intodlang:masterfrom
ibuclaw:fenv
Aug 7, 2017
Merged

core.stdc.fenv: Add platform-specific FE_XXX flags#1554
dlang-bot merged 1 commit intodlang:masterfrom
ibuclaw:fenv

Conversation

@ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Apr 30, 2016

It has been a pet peeve of mine for a while that these are defined as a different name in std.math, but not reflected here.

FE_TONEAREST = 0, ///
FE_DOWNWARD = 0x400, ///
FE_UPWARD = 0x800, ///
FE_TOWARDZERO = 0xC00, ///
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a dumb question - why do we duplicate this? Can't we combine these two?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of X86_Any or PPC_Any is discouraged.

@ibuclaw
Copy link
Member Author

ibuclaw commented Jan 15, 2017

Ping? Anything else apart from nitpicking that needs addressing?

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@ibuclaw
Copy link
Member Author

ibuclaw commented Aug 6, 2017

Rebased, added more targets.

@PetarKirov
Copy link
Member

Error: dub search dub failed

@ibuclaw The dub test failed on jenkins because of network issues, which usually go away if you restart the test (I've just done so). If that happens in the future you login on Jenkins with your GitHub account and restart it yourself.

Copy link
Member

@PetarKirov PetarKirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlang-bot dlang-bot merged commit 344fbe2 into dlang:master Aug 7, 2017
@PetarKirov
Copy link
Member

PetarKirov commented Aug 7, 2017

3 of 4 checks passed

(I missed the fact that Jenkins is not required when I added the auto-merge label, but given results of the previous Jenkins test, this change is extremely unlikely to cause any problems.)

@ibuclaw ibuclaw deleted the fenv branch August 7, 2017 18:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants