This repository was archived by the owner on Oct 12, 2022. It is now read-only.
[critical] change hashOf() to safe interface#1593
Merged
schveiguy merged 1 commit intodlang:masterfrom Jun 15, 2016
Merged
Conversation
| * The default hash implementation. | ||
| * | ||
| * Copyright: Copyright Sean Kelly 2009 - 2009. | ||
| * Copyright: Copyright Sean Kelly 2009 - 2016. |
Member
Author
There was a problem hiding this comment.
That would be inaccurate, as the year should be the last year the code was worked on rather than the year the documentation was generated.
Member
Author
|
This turns out to be a critical bug fix, as many uses of hashOf() are incorrect in that they are passing '0' as the length of the hash!! Just goes to show the evils of default arguments coupled with multiple incompatible definitions of hashOf(). This doesn't actually fix the bugs I found, but is a precursor to getting them fixed. Please don't delay pulling this. |
WalterBright
changed the title
Member
|
Auto-merge toggled on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When this gets pulled, all users of hashOf() need to be changed, and the old way deprecated.