Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Remove the WEB macro in favor of HTTP#1594

Merged
dlang-bot merged 1 commit intodlang:masterfrom
wilzbach:kill_web2
Jan 4, 2018
Merged

Remove the WEB macro in favor of HTTP#1594
dlang-bot merged 1 commit intodlang:masterfrom
wilzbach:kill_web2

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Jun 15, 2016

Small-scale follow-up to dlang/phobos#4411 and dlang/phobos#4432 that just deprecates WEB in favor of HTTP.

sed 's/\$(WEB/\$(HTTP/g' -i **/*.{asm,c,d,S}

Converting websites that support SSL to SSL will be a separate PR, s.t. DAutoTest can tell us whether there are any differences between the builds. For reasons and argumentation see #4411.

@MartinNowak
Copy link
Member

MartinNowak commented Aug 8, 2016

Just reran and pushed the result to my fork.
Please reset your branch to 6e3c558 or rerun yourself.

@wilzbach
Copy link
Contributor Author

wilzbach commented Aug 8, 2016

Just reran and pushed the result to my fork.

Thanks, feel free to close this & open your a new PR next time (I don't mind at all).

Please reset your branch to 6e3c558 or rerun yourself.

Done ;-)

@rainers
Copy link
Member

rainers commented Jul 14, 2017

Needs a rebase again.

There are also instances of boost links using $(LINK2 ...)

@CyberShadow
Copy link
Member

There are also instances of boost links using $(LINK2 ...)

LINK2 is what we should be moving towards, but Andrei doesn't like it. WEB is, however, completely redundant, and getting rid of it is uncontroversial.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@wilzbach
Copy link
Contributor Author

wilzbach commented Jan 4, 2018

WEB is, however, completely redundant, and getting rid of it is uncontroversial.

Yep. Finally got to rebasing this for the third time. Anyone around for a quick pull?

@Burgos
Copy link
Contributor

Burgos commented Jan 4, 2018

It's red, though :thinkingface:.

@Burgos
Copy link
Contributor

Burgos commented Jan 4, 2018

Looks like a timeout.

sed 's/\$(WEB/\$(HTTP/g' -i **/*.{asm,c,d,S}
@wilzbach
Copy link
Contributor Author

wilzbach commented Jan 4, 2018

.generated/stable_dmd-2.077.1/dmd2/linux/bin64/dub upgrade --missing-only --root=dpl-docs
Upgrading project in /dev/shm/dtest/work/repo/dlang.org/dpl-docs
Fetching ddox 0.16.7 (getting selected version)...
Fetching libevent 2.0.2+2.0.16 (getting selected version)...
ZipException: no end record
posix.mak:779: recipe for target 'dpl-docs' failed

So DUB failed here :/
Though I'm wondering why DUB doesn't retry the download (from the same server and/or the mirror)

@schveiguy
Copy link
Member

Just waiting on that doc test to report no changes :) LGTM otherwise.

@schveiguy
Copy link
Member

Huh, what is that verbatim thing? It doesn't look like anything that is used in the actual docs, so I will pull. Only differences I'm seeing is that WEB has changed to HTTP.

@wilzbach
Copy link
Contributor Author

wilzbach commented Jan 4, 2018

Huh, what is that verbatim thing?

It dumps the generated Ddoc pages without applying any macros. Sometimes it's useful/faster to compare ddoc build diff (though not that often).
However, I don't know either why it's only displayed for 8 pages - maybe we don't generate .verbatim files for all modules?

@schveiguy
Copy link
Member

I don't know either why it's only displayed for 8 pages

that's what confused me also!

@dlang-bot dlang-bot merged commit 633976f into dlang:master Jan 4, 2018
@andralex
Copy link
Member

andralex commented Jan 4, 2018

Great, thanks! BTW perhaps we should switch to HTTPS for important links, e.g. license - $(HTTPS boost.org/LICENSE_1_0.txt, Boost License 1.0) would be the canonical form. They still redirect to HTTP but it's on their side. cc @CyberShadow

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants