Remove the WEB macro in favor of HTTP#1594
Conversation
|
Just reran and pushed the result to my fork. |
Thanks, feel free to close this & open your a new PR next time (I don't mind at all).
Done ;-) |
|
Needs a rebase again. There are also instances of boost links using $(LINK2 ...) |
LINK2 is what we should be moving towards, but Andrei doesn't like it. WEB is, however, completely redundant, and getting rid of it is uncontroversial. |
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
Yep. Finally got to rebasing this for the third time. Anyone around for a quick pull? |
|
It's red, though :thinkingface:. |
|
Looks like a timeout. |
sed 's/\$(WEB/\$(HTTP/g' -i **/*.{asm,c,d,S}
So DUB failed here :/ |
|
Just waiting on that doc test to report no changes :) LGTM otherwise. |
|
Huh, what is that verbatim thing? It doesn't look like anything that is used in the actual docs, so I will pull. Only differences I'm seeing is that WEB has changed to HTTP. |
It dumps the generated Ddoc pages without applying any macros. Sometimes it's useful/faster to compare ddoc build diff (though not that often). |
that's what confused me also! |
|
Great, thanks! BTW perhaps we should switch to HTTPS for important links, e.g. license - |
Small-scale follow-up to dlang/phobos#4411 and dlang/phobos#4432 that just deprecates
WEBin favor ofHTTP.Converting websites that support SSL to SSL will be a separate PR, s.t. DAutoTest can tell us whether there are any differences between the builds. For reasons and argumentation see #4411.