This repository was archived by the owner on Oct 12, 2022. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 411
Fix issue 16211 - Cyclic dependencies broken again #1602
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
4b161d5
Fixes issue 16211 - Fix cycle detection algorithm. Left the old algor…
schveiguy 96cfbe0
remove old constructor sorting algorithm.
schveiguy a3c7270
More improvements.
schveiguy 277f9f2
Prune branches from the search when the non-relevant nodes have have
schveiguy 8752d18
Switch to manual stack allocation for finding relevant dependencies.
schveiguy 3de899d
Change pruning of non-relevant nodes to be at deepest level, actually
schveiguy e8e34a1
Applied dfmt
schveiguy bd1ebb5
Address all critique.
schveiguy 35ccbc1
Realloc to size 0 data returns null, so avoid that situation.
schveiguy 89b1ef3
Remove check for null module info -- this can't happen anymore.
schveiguy 50a40f7
Realized there's no reason to pass cyclePath by reference.
schveiguy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice