Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Change aliases to new syntax in several files#1741

Merged
dlang-bot merged 4 commits intodlang:masterfrom
JackStouffer:alias
Jul 3, 2017
Merged

Change aliases to new syntax in several files#1741
dlang-bot merged 4 commits intodlang:masterfrom
JackStouffer:alias

Conversation

@JackStouffer
Copy link
Contributor

Modernization and clarity.

@joakim-noah
Copy link
Contributor

FYI, #1002.

@JackStouffer
Copy link
Contributor Author

Martin seems to be in favor of the new syntax.

The area I disagree with him on is the idea that people will just incrementally change the code to the new syntax. Sorry to be a cynic but if it hasn't happened after two years of pull requests it isn't going to happen.

@PetarKirov
Copy link
Member

Sorry to be a cynic but if it hasn't happened after two years of pull requests it isn't going to happen.

d7581e8#diff-955ac66e3ac3a2edbe727ac0cf9fba4dR72 :P

Though I agree that it's better to do it once and be done with it.

Copy link
Contributor

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and we really should start to deprecate the old syntax...

@JackStouffer
Copy link
Contributor Author

Ping @wilzbach. Do you think you could merge this?

@CyberShadow
Copy link
Member

What's happening with this useless coverage thing, argh

@wilzbach wilzbach reopened this Jul 3, 2017
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @JackStouffer!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@wilzbach
Copy link
Contributor

wilzbach commented Jul 3, 2017

Ping @wilzbach. Do you think you could merge this?

Sorry - totally slipped through my radar. Rebased & auto-merging now, finally :)

@dlang-bot dlang-bot merged commit 6573792 into dlang:master Jul 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants