Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

[scope] add 'scope' to delegates#1753

Merged
MartinNowak merged 1 commit intodlang:masterfrom
WalterBright:scope-gc
Feb 7, 2017
Merged

[scope] add 'scope' to delegates#1753
MartinNowak merged 1 commit intodlang:masterfrom
WalterBright:scope-gc

Conversation

@WalterBright
Copy link
Member

This is to resolve the following -dip1000 generated errors:

src/gc/impl/conservative/gc.d(2150): Error: function core.thread.thread_scanAll (scope void delegate(void*, void*) nothrow scope scan) is not callable using argument types (void delegate(void* pbot, void* ptop) nothrow)
src/gc/impl/conservative/gc.d(2397): Error: function core.thread.thread_processGCMarks (scope int delegate(void* addr) nothrow scope isMarked) is not callable using argument types (int delegate(void* addr) nothrow)

I.e. a non-scope delegate cannot be used where a scope delegate is expected.

@WalterBright
Copy link
Member Author

Auto-merge toggled on

@WalterBright
Copy link
Member Author

Auto-merge toggled off

@WalterBright
Copy link
Member Author

@MartinNowak ping

@MartinNowak
Copy link
Member

Auto-merge toggled on

@MartinNowak
Copy link
Member

Also see dlang/dmd#6495 (comment)

@WalterBright
Copy link
Member Author

CyberShadow/DAutoTest is failing with the same error on every PR of mine. It's clearly something broken that has been merged in somewhere, and has nothing to do with this PR.

@MartinNowak MartinNowak merged commit 4dec622 into dlang:master Feb 7, 2017
@WalterBright WalterBright deleted the scope-gc branch February 7, 2017 11:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants