Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Remove support for deprecated built-in array.reverse property.#1770

Merged
dlang-bot merged 1 commit intodlang:masterfrom
quickfur:remove-builtin-reverse
Jul 5, 2017
Merged

Remove support for deprecated built-in array.reverse property.#1770
dlang-bot merged 1 commit intodlang:masterfrom
quickfur:remove-builtin-reverse

Conversation

@quickfur
Copy link
Member

Depends on: dlang/dmd#6554

@quickfur
Copy link
Member Author

Note: I couldn't remove _adSort et call because apparently sorting is required by the treap implementation, and I couldn't see any easy replacement without needing to import Phobos, which is a no-no.

@jmdavis
Copy link
Member

jmdavis commented May 5, 2017

The dmd tests are failing on the autotester, though glancing at the results, it's not clear to me why they're failing.

@aG0aep6G
Copy link
Contributor

aG0aep6G commented May 5, 2017

The dmd tests are failing on the autotester, though glancing at the results, it's not clear to me why they're failing.

dmd/test/runnable/test20.d uses .reverse (see lines 734 through 759).

Copy link
Contributor

@MoritzMaxeiner MoritzMaxeiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the problematic dmd tests were removed

@dlang-bot dlang-bot merged commit 62845b7 into dlang:master Jul 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants