This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Add tests for class/struct/array comparisons#1784
Merged
MartinNowak merged 2 commits intodlang:masterfrom Mar 4, 2017
Merged
Conversation
The introduction of the .gitignore rule lacked any description or rationale (PR dlang#682), so I'm guessing this is to allow people to create a local Makefile so that `make` works without needing to specify `-f posix.mak`. Fix this rule so that it doesn't apply to the actually versioned Makefile files under the test directory.
CyberShadow
force-pushed
the
pull-20170304-141153
branch
from
f7b03fc to
cdd0fee
Compare
PR dlang#1781 is moving array comparisons to a new template; the initial implementation included changes which may have introduced performance and behavior regressions. Add explicit tests for these cases to detect such regressions.
CyberShadow
force-pushed
the
pull-20170304-141153
branch
from
cdd0fee to
d388315
Compare
Member
|
Auto-merge toggled on |
Member
|
Thanks! |
Member
Author
|
This would be one case where squashing is inappropriate :) Martin already enabled the old auto-merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1781 is moving array comparisons to a new template; the initial implementation included changes which may have introduced performance and behavior regressions.
Add explicit tests for these cases to detect such regressions.