Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Comments

windows: make precise scanning of DATA and TLS optional#1798

Merged
dlang-bot merged 4 commits intodlang:masterfrom
rainers:dataptr_opt
Jun 17, 2017
Merged

windows: make precise scanning of DATA and TLS optional#1798
dlang-bot merged 4 commits intodlang:masterfrom
rainers:dataptr_opt

Conversation

@rainers
Copy link
Member

@rainers rainers commented Apr 2, 2017

This makes use of the pointer reference information written by the compiler. If it passes I think it would make sense to add it to the release. It should be opt-in, though, so I'd change the default before merging.

@rainers rainers changed the base branch from stable to master April 15, 2017 13:58
@rainers
Copy link
Member Author

rainers commented Apr 15, 2017

Rebased back to master and added changelog.

@rainers
Copy link
Member Author

rainers commented May 2, 2017

Finally figured one/the cause for the crashes: dlang/phobos#5357

@rainers rainers changed the title [do not merge] windows: make precise scanning of DATA and TLS optional windows: make precise scanning of DATA and TLS optional May 7, 2017
@rainers
Copy link
Member Author

rainers commented May 7, 2017

Now that this has passed the auto tester for a couple of days the spurious failures are likely gone after the fix to phobos. I changed the default to conservative scanning, so this can be considered for merging.

@MartinNowak MartinNowak added this to the 2.075.0-b1 milestone Jun 17, 2017
@rainers
Copy link
Member Author

rainers commented Jun 18, 2017

Thanks. Added a documentation PR here: dlang/dlang.org#1724

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants