This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Fixup fiber guard page changelog#1821
Merged
MartinNowak merged 1 commit intodlang:stablefrom Jun 26, 2017
Merged
Conversation
During the review of GitHub dlang#1698, the "END OF FIBRE" marker data was removed to avoid dirtying the guard page. Hence, the corresponding comment in the release notes doesn't apply anymore.
Contributor
|
Whoops, thanks! |
nemanja-boric-sociomantic
approved these changes
May 6, 2017
Contributor
|
cc @MartinNowak |
Contributor
|
The changelog has already been put on dlang.org - could you please make a PR to the Dlang.org repository? I am sorry that this went under the radar. |
Contributor
|
No problems, I'll submit a PR there. |
nemanja-boric-sociomantic
added a commit
to nemanja-boric-sociomantic/dlang.org
that referenced
this pull request
Jun 26, 2017
During the review of GitHub dlang/druntime#1698, the "END OF FIBER" marker data was removed to avoid dirtying the guard page. Hence, the corresponding comment in the release notes doesn't apply anymore. See dlang/druntime#1821
Contributor
Contributor
|
Thanks for your pull request, @klickverbot! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the review of GitHub #1698, the "END OF FIBRE" marker data
was removed to avoid dirtying the guard page. Hence, the corresponding
comment in the release notes doesn't apply anymore.