Conversation
| # | ||
| # Note: | ||
| # Keep this file in sync between druntime, phobos, and dmd repositories! | ||
| # Source: https://github.com/dlang/druntime/blob/master/osmodel.mak |
There was a problem hiding this comment.
I don't understand the purpose of this source link.
There was a problem hiding this comment.
We have them in all the dmd source code files - it's for the same reason - an easy way to find out things like the history of the file.
| # MODEL_FLAG = one of { -m32, -m64 } | ||
| # | ||
| # Note: | ||
| # Keep this file in sync between druntime, phobos, and dmd repositories! |
There was a problem hiding this comment.
I guess this needs accompanying PRs to dmd and phobos as per the comment.
There was a problem hiding this comment.
Yes, but after this one.
There was a problem hiding this comment.
I guess this needs accompanying PRs to dmd and phobos as per the comment.
FWIW Phobos and Druntime already depend on DMD and I see no logical reason to have redundant copies of this files...
I actually tried to push for this once:
But was stopped by people not wanting to have the DMD Makefile auto-checking out the tools repo.
However, we could go with the small scale solution and at least get rid of the osmodel files at Phobos, Druntime ...
Dlang.org was controversial as well due to automatic git clone
There was a problem hiding this comment.
I wonder if there's a way to fix this from the github side - is it possible to link a file across projects?
There was a problem hiding this comment.
I wonder if there's a way to fix this from the github side - is it possible to link a file across projects?
Yes, it's called submodules, and they come with their share of problems. (You need to remember to do git submodule update any time you move HEAD.)
|
codecov should not consider this for coverage. Why is jenkins failing? cc @MartinNowak |
|
https://ci.dlang.io/blue/organizations/jenkins/dlang-org%2Fdruntime/detail/PR-1843/1/pipeline#step-480-log-330 - looks like configuration / environment issue. We can try restarting Jenkins by closing & reopening the PR. |
|
let's see |
6 participants
Makefiles need comments, too.