Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Comments

Revert "Add SO_REUSEPORT constant"#1885

Merged
dlang-bot merged 1 commit intomasterfrom
revert-1879-soreusse
Jul 20, 2017
Merged

Revert "Add SO_REUSEPORT constant"#1885
dlang-bot merged 1 commit intomasterfrom
revert-1879-soreusse

Conversation

@wilzbach
Copy link
Contributor

Temporarily reverts #1879

Allows the Project Tester (and other projects that test dmd-nightly) to be green. We can revert the revert and keep it in the queue until this has been fixed at the projects. As a general policy Jenkins (the project tester) should always be green.

CC @CyberShadow

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@CyberShadow
Copy link
Member

CyberShadow commented Jul 20, 2017

Can we make Jenkins required again after this?

@wilzbach
Copy link
Contributor Author

Can we make Jenkins required again after this?

That was the idea - Martin has worked quite a bit on making it more stable, so we should give it a try again ;-)

@Burgos
Copy link
Contributor

Burgos commented Jul 20, 2017

Looks like Jenkins can't handle "GitHub" reverts since it tries to find a matching branch in dmd/phobos/dub/et al.: https://ci.dlang.io/job/dlang-org/job/druntime/job/revert-1879-soreusse/

For some reason, jenkins/pr-merge job didn't popup for me. All good.

@Burgos
Copy link
Contributor

Burgos commented Jul 20, 2017

dlang/ci#56

@Burgos
Copy link
Contributor

Burgos commented Jul 20, 2017

@dlang-bot dlang-bot merged commit e78a928 into master Jul 20, 2017
@wilzbach wilzbach deleted the revert-1879-soreusse branch July 20, 2017 16:33
@MartinNowak
Copy link
Member

Can we make Jenkins required again after this?

We also have a new feature, you can now login to https://ci.dlang.io/ with your Github account and should be able to replay tests (see dlang/ci#36).

When you click on the linked jenkins status here in GH, the login button is a bit hidden (trying to change that with jenkinsci/blueocean-plugin#1260).
For example going to https://ci.dlang.io/job/dlang-org/job/druntime/job/PR-1886/1/display/redirect,
click on the x
x
to close the overlayed result page, then you should see a login button in the normal header.
login

@CyberShadow
Copy link
Member

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants