Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

[Trivial] core.thread: Fix missing alignment of global#1888

Merged
wilzbach merged 1 commit intodlang:stablefrom
kinke:stable
Jul 26, 2017
Merged

[Trivial] core.thread: Fix missing alignment of global#1888
wilzbach merged 1 commit intodlang:stablefrom
kinke:stable

Conversation

@kinke
Copy link
Contributor

@kinke kinke commented Jul 23, 2017

No description provided.

@dlang-bot dlang-bot added the Trivial typos, formatting, comments label Jul 23, 2017
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@kinke
Copy link
Contributor Author

kinke commented Jul 24, 2017

Are pulls against stable discouraged these days? CI keeps having problems with it.

@wilzbach
Copy link
Contributor

Are pulls against stable discouraged these days? CI keeps having problems with it.

I fixed this yesterday: dlang/dlang.org#1839

Sadly you need to rebase the PR, so that DAutoTest reruns. The trick is to do sth like this:

git commit --amend--no-edit

To get a new sha hash.

@kinke
Copy link
Contributor Author

kinke commented Jul 24, 2017

Thanks, done. Requires a new auto-merge OK though.

@wilzbach
Copy link
Contributor

Requires a new auto-merge OK though.

Done :)

@wilzbach
Copy link
Contributor

DAutoTest has been fixed in dlang/dlang.org#1842
As this is a trivial change, it passes on all CIs and for some reason I can't force push here, I am manually overwriting this to avoid yet another ping-pong loop (this one-line PR has had much more activity than needed already).

@wilzbach wilzbach merged commit 4392df1 into dlang:stable Jul 26, 2017
@kinke kinke deleted the stable branch July 26, 2017 07:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Trivial typos, formatting, comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants