Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Comments

core.mutex: @nogc lock/unlock#1889

Closed
wilzbach wants to merge 1 commit intodlang:masterfrom
wilzbach:nogc-mutex
Closed

core.mutex: @nogc lock/unlock#1889
wilzbach wants to merge 1 commit intodlang:masterfrom
wilzbach:nogc-mutex

Conversation

@wilzbach
Copy link
Contributor

I couldn't see any reason why they shouldn't be @nogc - their implementations are @nogc.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Auto-close Bugzilla Description
17691 core.mutex.Mutex : {lock,unlock} should be @nogc

@dlang-bot dlang-bot added the Enhancement New functionality label Jul 26, 2017
@PetarKirov
Copy link
Member

See #1728 (comment) for why you can't add attributes to those functions. Also the vibe.d failure is quite indicative.

New code should use the core.sync.mutex.Mutex.*_nothrow() functions.

@PetarKirov PetarKirov closed this Jul 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Enhancement New functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants