Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

add missing ^^ and ^^= arrayop support#1899

Merged
WalterBright merged 1 commit intodlang:masterfrom
MartinNowak:array_pow
Aug 10, 2017
Merged

add missing ^^ and ^^= arrayop support#1899
WalterBright merged 1 commit intodlang:masterfrom
MartinNowak:array_pow

Conversation

@MartinNowak
Copy link
Member

@MartinNowak MartinNowak commented Aug 10, 2017

fixup for #1891, required by dlang/dmd#7032.
Unfortunately not really possible to test those with druntime's unittests as PowExp depends on phobos' std.math.pow.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @MartinNowak!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@ibuclaw
Copy link
Member

ibuclaw commented Aug 10, 2017

It may not be a bad idea to move it to druntime. As phobos should be optional.

@WalterBright WalterBright merged commit 4575297 into dlang:master Aug 10, 2017
@MartinNowak
Copy link
Member Author

MartinNowak commented Aug 10, 2017

It may not be a bad idea to move it to druntime. As phobos should be optional.

Yes indeed, let's take this as a hint that having the compiler rely on phobos functions as intrinsics is not the best idea. In fact gcc/gdc's explicit low-level intrinsics seem like a much better approach, easy enough to wrap those where wanted now that inlining works properly.

@MartinNowak MartinNowak deleted the array_pow branch August 10, 2017 14:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants