This repository was archived by the owner on Oct 12, 2022. It is now read-only.
add missing ^^ and ^^= arrayop support#1899
Merged
WalterBright merged 1 commit intodlang:masterfrom Aug 10, 2017
Merged
Conversation
Contributor
|
Thanks for your pull request, @MartinNowak! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
Member
|
It may not be a bad idea to move it to druntime. As phobos should be optional. |
Member
Author
Yes indeed, let's take this as a hint that having the compiler rely on phobos functions as intrinsics is not the best idea. In fact gcc/gdc's explicit low-level intrinsics seem like a much better approach, easy enough to wrap those where wanted now that inlining works properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixup for #1891, required by dlang/dmd#7032.
Unfortunately not really possible to test those with druntime's unittests as PowExp depends on phobos' std.math.pow.