Conversation
MartinNowak
commented
Aug 19, 2017
- native TLS supported since 2.072.0
- native TLS supported since 2.072.0
|
Thanks for your pull request, @MartinNowak! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
|
CyberShadow/DAutoTest fails due to dlang/dlang.org#1796. |
|
@MartinNowak @ZombineDev 32bit is still using emulated TLS: https://github.com/dlang/dmd/blob/master/src/ddmd/toobj.d#L1239. To elaborate, I never got the implementation to work on 32bit, although it's using the same scheme as far as I can see. Since 32bit macOS is basically a dead platform, Walter decided it wasn't worth spending time on it and the 64bit implementation was approved. There are a few cases where 32bit macOS might still be interesting:
|
ibuclaw
left a comment
There was a problem hiding this comment.
Decide what to do about OSX 32bit.
|
Yes, smelled a bit as if 32-bit was still relying on this. Any reference to the OSX TLS implementation? Can't find any in dlang/dmd#5346, but I guess you didn't reverse engineer all of it @jacob-carlborg. |
Keep as long as it's not much to keep. |
There's no official reference, as far as I know. What I found out is documented here [1][2]. [1] https://github.com/dlang/dmd/blob/master/src/ddmd/toobj.d#L1212 |
|
TLS was supported before Xcode 8. |
|
TLS is supported on OS X 10.7+. |
Unfortunately doesn't document from what you derived this. Guess from their runtime linker and llvm/clang, right? |
From dyld and looking at the assembly and object dumps from Clang. |
|
Darwin_64_32 fails consistently on autotester, so it looks we can't move forward with this PR. Please reopen, if I'm misunderstanding. |