Add musl libc definitions to: src_core_thread#2007
Conversation
|
Thanks for your pull request, @yshui! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Some tips to help speed things up:
Bear in mind that large or tricky changes may require multiple rounds of review and revision. Please see CONTRIBUTING.md for more information. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
|
No need for a separate pull for every file, a good way to split it is three pulls, like the recent DragonFlyBSD pulls. I'll look at these file pulls for now- small is fine- but for the rest of your original pull, splitting it like the DragonFly pull is a good idea. |
@joakim-noah I already did... |
|
Yes, you already split it by file for some of your original massive pull #1997, but for the rest, please just split it in two, not every file by itself. |
475cf47 to
d355984
Compare
|
Rebased to master fix the CircleCi & DAutoTest failures. |
|
All these are just additions and look reasonable to me. One pull request per package (core.stdc, core.sys, etc) is the usual thing to do for ease of review. |
|
@ibuclaw @joakim-noah So it's ok to submit one PR per module? |
|
Yes, your initial PR was just a bit too large to be reviewed in one piece. |
|
@yshui - Yes, of course its fine, although 4 PRs would have been fine also. One for |
|
One pull per module is way too small for changes like this, please just remove all these merged patches from your original pull #1997 and we'll get that reduced patch in. |
|
@joakim-noah OK. I'm just waiting for all the submitted patches to merge before submitting the rest |
|
No, don't submit the rest separately. Just trim down #1997 of the parts that were already merged, and we'll get that first pull in. |
|
@joakim-noah I meant to say that I'll submit the rest splitted into 4 parts after the outstanding PRs are merged. |
|
If you like, but simply removing these merged patches from #1997 should be enough to get that one in. |
Splitted from #1997