Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Comments

Add musl libc definitions to: src_core_sys_posix_dlfcn#2015

Merged
dlang-bot merged 1 commit intodlang:masterfrom
yshui:musl_libc_src_core_sys_posix_dlfcn
Jan 15, 2018
Merged

Add musl libc definitions to: src_core_sys_posix_dlfcn#2015
dlang-bot merged 1 commit intodlang:masterfrom
yshui:musl_libc_src_core_sys_posix_dlfcn

Conversation

@yshui
Copy link
Contributor

@yshui yshui commented Dec 26, 2017

Splitted from #1997

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @yshui! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@yshui yshui changed the base branch from stable to master December 26, 2017 05:55
@wilzbach
Copy link
Contributor

Rebased to master to fix the DAutoTest & CircleCi failures.

@wilzbach wilzbach force-pushed the musl_libc_src_core_sys_posix_dlfcn branch from 743dc60 to 9042270 Compare December 29, 2017 16:34
@dlang-bot dlang-bot added Needs Rebase needs a `git rebase` performed and removed Needs Rebase needs a `git rebase` performed labels Jan 1, 2018
@wilzbach
Copy link
Contributor

(restarted Jenkins)

@wilzbach
Copy link
Contributor

Trying the close & reopen trick for Jenkins

@wilzbach wilzbach closed this Jan 14, 2018
@wilzbach wilzbach reopened this Jan 14, 2018
@wilzbach wilzbach force-pushed the musl_libc_src_core_sys_posix_dlfcn branch from 9042270 to d1148e7 Compare January 14, 2018 04:21
@dlang-bot dlang-bot merged commit 18be8bf into dlang:master Jan 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants