This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Switch linkage of ___tls_get_addr to extern(C).#2034
Merged
dlang-bot merged 1 commit intodlang:masterfrom Jul 3, 2019
ibuclaw:externctls
Merged
Switch linkage of ___tls_get_addr to extern(C).#2034dlang-bot merged 1 commit intodlang:masterfrom ibuclaw:externctls
dlang-bot merged 1 commit intodlang:masterfrom
ibuclaw:externctls
Conversation
Contributor
|
Thanks for your pull request, @ibuclaw! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + druntime#2034" |
Member
Author
|
Rebased now that dlang/dmd#7620 is in, lets see what the test-suite has to say... |
Contributor
|
I guess today isn't your lucky day - Darwin_64_32 fails with: |
Member
Author
|
Does someone have a box I can use for debugging? |
Contributor
Member
Author
|
Not for osx? |
Contributor
|
Whoops, I got carried away. Yes, please rebase. |
Member
Author
|
I imagine that we still need to work out what is wrong with the compiler first. ;-) |
Contributor
|
I have an OSX box and could narrow the problem, or we could just ditch 32bit OSX :) |
Contributor
Apple deprecate support for 32-bit a long time ago and they will remove support for it completely with the next version:
https://support.apple.com/en-us/HT208436 So please let's not waste time on a dead horse. |
Contributor
Yes please. But there might be necessary to convenience some other people. |
Contributor
|
OSX32-bit support was dropped can this be closed or merged? |
Contributor
I would guess so. Anyone else? |
Member
Author
|
There's still the compiler component to remove. |
Contributor
|
Does that need to be done before this? |
Member
Author
|
I wouldn't have thought so. From memory, the compiler side is just a special case for recognizing and not mangling symbols named |
Contributor
So if it's |
Member
Author
|
I'm rebasing to have another look at what the error is. Switching from extern(D) to extern(C) would change the ABI on 32bit (pointer passed in register vs. pushed on stack), maybe there's something else in the compiler that needs to change in lock-step. |
Member
Author
|
Great, the testsuite passes now because 32bit Darwin is disabled... |
Member
Author
|
Might as well merge this then? I'll see if I can track down possible OSX 32-bit problems in the teardown PR that will be sent to dmd. What I'll be notably looking for it anything that suggests the D calling convention around ___tls_get_addr. |
thewilsonator
approved these changes
Jul 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename to __tls_get_addr to keep same ABI.
This depends on dlang/dmd#7620 getting merged.