Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Comments

Run CircleCi coverage for 32-bit too#2061

Merged
dlang-bot merged 1 commit intodlang:masterfrom
wilzbach:circleci-32
Jan 26, 2018
Merged

Run CircleCi coverage for 32-bit too#2061
dlang-bot merged 1 commit intodlang:masterfrom
wilzbach:circleci-32

Conversation

@wilzbach
Copy link
Contributor

See also: dlang/dmd#7718

@wilzbach wilzbach requested a review from andralex as a code owner January 24, 2018 23:06
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@wilzbach wilzbach added the Trivial typos, formatting, comments label Jan 24, 2018
@wilzbach
Copy link
Contributor Author

Jenkins failure is unrelated and should be gone soon (-> dlang/ci#132)

@wilzbach
Copy link
Contributor Author

wilzbach commented Jan 25, 2018

75.411% (+1.001%) compared to 2d45fcb

It has a measurable effect 👻

Copy link
Member

@andralex andralex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wilzbach
Copy link
Contributor Author

We initially planned to run the coverage on 32-bit too (hence there were no changes to .circleci/run.sh needed).
However, for CircleCi 1.0 the parallelism was always set to 1. A couple of weeks ago we switched to CircleCi 2.0 and thus the switch to parallelism: 2 is now possible.
The druntime test suite runs very quickly (~2 mins) + there aren't that many PRs compared to DMD or Phobos, so we don't have to worry about this here.
FWIW we run CircleCi with parallelism: 3 at dlang/dmd and the test take ~18 mins to run there, so if we ever run into a bottleneck it's at dmd.

@dlang-bot dlang-bot merged commit 7e0a448 into dlang:master Jan 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Trivial typos, formatting, comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants