Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Comments

Duration examples fail to run on dlang.org without import.#2086

Merged
dlang-bot merged 1 commit intodlang:masterfrom
smandy:master
Feb 13, 2018
Merged

Duration examples fail to run on dlang.org without import.#2086
dlang-bot merged 1 commit intodlang:masterfrom
smandy:master

Conversation

@smandy
Copy link
Contributor

@smandy smandy commented Feb 13, 2018

The issue...

go to ...

https://dlang.org/phobos/core_time.html

Search for 'edit' ( i.e. find the first runnable example ). Run the example, for me anyway example is broken.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @smandy! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@jmdavis
Copy link
Member

jmdavis commented Feb 13, 2018

The example was written long before we put any import statements in examples, and because it involves std.datetime, and it's in druntime, it can't be a ddoc-ed unittest, which is why the circleci stuff has never complained about it.

@jmdavis jmdavis added Trivial typos, formatting, comments auto-merge labels Feb 13, 2018
@wilzbach
Copy link
Contributor

which is why the circleci stuff has never complained about it.

I just realized that the publictests checking is only done for Phobos:

#2087

@jmdavis
Copy link
Member

jmdavis commented Feb 13, 2018

Well, it wouldn't have helped in this case. It also doesn't affect druntime all that much, since most of druntime's public modules don't depend on each other much. But it doesn't hurt to add a check.

@dlang-bot dlang-bot merged commit dd5fe6f into dlang:master Feb 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Trivial typos, formatting, comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants