Duration examples fail to run on dlang.org without import.#2086
Duration examples fail to run on dlang.org without import.#2086dlang-bot merged 1 commit intodlang:masterfrom
Conversation
|
Thanks for your pull request and interest in making D better, @smandy! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
|
The example was written long before we put any import statements in examples, and because it involves std.datetime, and it's in druntime, it can't be a ddoc-ed unittest, which is why the circleci stuff has never complained about it. |
I just realized that the publictests checking is only done for Phobos: |
|
Well, it wouldn't have helped in this case. It also doesn't affect druntime all that much, since most of druntime's public modules don't depend on each other much. But it doesn't hurt to add a check. |
The issue...
go to ...
https://dlang.org/phobos/core_time.html
Search for 'edit' ( i.e. find the first runnable example ). Run the example, for me anyway example is broken.