Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Comments

Fix Issue 18932 - core.internal.hash.hashOf(val, seed) ignores seed when val is a raw pointer#2202

Merged
dlang-bot merged 1 commit intodlang:masterfrom
n8sh:core-hash-18932
Jun 3, 2018
Merged

Fix Issue 18932 - core.internal.hash.hashOf(val, seed) ignores seed when val is a raw pointer#2202
dlang-bot merged 1 commit intodlang:masterfrom
n8sh:core-hash-18932

Conversation

@n8sh
Copy link
Member

@n8sh n8sh commented Jun 1, 2018

This PR makes this pass:

unittest
{
    import core.internal.hash : hashOf;
    assert(hashOf(null, 0) != hashOf(null, 123456789));
}

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @n8sh!

Bugzilla references

Auto-close Bugzilla Severity Description
18932 normal core.internal.hash.hashOf(val, seed) ignores seed when val is a raw pointer

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2202"

@dlang-bot dlang-bot added the Bug Fix Include reference to corresponding bugzilla issue label Jun 1, 2018
@wilzbach
Copy link
Contributor

wilzbach commented Jun 3, 2018

Once #2205 has been merged, CircleCi can be restarted and this PR can finally get merged.

@dlang-bot dlang-bot merged commit 52f2367 into dlang:master Jun 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Bug Fix Include reference to corresponding bugzilla issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants