This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Make -betterC code nothrow and @nogc#2203
Closed
JinShil wants to merge 1 commit intodlang:masterfrom
JinShil:betterC_nothrow_object_d
Closed
Make -betterC code nothrow and @nogc#2203JinShil wants to merge 1 commit intodlang:masterfrom JinShil:betterC_nothrow_object_d
JinShil wants to merge 1 commit intodlang:masterfrom
JinShil:betterC_nothrow_object_d
Conversation
Contributor
|
Thanks for your pull request, @JinShil! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + druntime#2203" |
Contributor
Author
|
Gah. My mistake. _destructRecurse is a template. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rework of #2184, but since #2194 has already been merged, the context and motivations for it have changed.
-betterC does not support throwing exceptions or garbage collection. Users should, therefore, always be attributing their -betterC code with
nothrowand@betterC. To ensure -betterC builds receive D's compile-time correctness guarantees, runtime implementations, when compiled with -betterC, should also be attributednothrowand@nogc.This PR is still required for dlang/dmd#8253, but is still valuable (and fundamentally correct) despite the fate of that PR.