Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Comments

Add base address offset for PIE executables#2215

Closed
yshui wants to merge 1 commit intodlang:masterfrom
yshui:pie-backtrace
Closed

Add base address offset for PIE executables#2215
yshui wants to merge 1 commit intodlang:masterfrom
yshui:pie-backtrace

Conversation

@yshui
Copy link
Contributor

@yshui yshui commented Jun 14, 2018

Fix the file name and line number in backtrace for PIE executables

@yshui yshui requested a review from andralex as a code owner June 14, 2018 14:38
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @yshui! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2215"

@yshui yshui requested a review from wilzbach as a code owner June 14, 2018 14:38
Fix the file name and line number in backtrace for PIE executables
@JinShil
Copy link
Contributor

JinShil commented Jun 14, 2018

Is this a fix for https://issues.dlang.org/show_bug.cgi?id=18068?

Also, see #2172

@yshui
Copy link
Contributor Author

yshui commented Jun 14, 2018

@JinShil Oh no! I'm duplicating someone else's work again.

@yshui yshui closed this Jun 14, 2018
@JinShil
Copy link
Contributor

JinShil commented Jun 14, 2018

@yshui, Well, given how that #2172 isn't going anywhere at the moment, feel fee to adopt it, or submit a competing PR. We need that bug fixed. cc @wilzbach

@yshui
Copy link
Contributor Author

yshui commented Jun 15, 2018

@JinShil What is needed to be done for #2172 ?

@JinShil
Copy link
Contributor

JinShil commented Jun 15, 2018

What is needed to be done for #2172 >

I'm not quite sure. You'll have to read through the comments and see if you can obtain any information about it. @wilzbach, being the author, may be able to provide you with more information.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants