This repository was archived by the owner on Oct 12, 2022. It is now read-only.
don't include windows.d in stdio.d#2336
Merged
dlang-bot merged 1 commit intodlang:masterfrom Oct 20, 2018
Merged
Conversation
Contributor
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + druntime#2336" |
WalterBright
force-pushed
the
noWindows.h
branch
from
c4271c5 to
5dc7a07
Compare
schveiguy
approved these changes
Oct 20, 2018
n8sh
added a commit
to n8sh/druntime
that referenced
this pull request
Dec 9, 2018
In general avoided removing core.sys.windows.windows imports from other core.sys.windows.* header files so imports-of-imports from them will not break. The exception is core.sys.windows.threadaux because it is imported by core.thread.
n8sh
added a commit
to n8sh/druntime
that referenced
this pull request
Dec 9, 2018
In general avoided removing non-private core.sys.windows.windows imports from other core.sys.windows.* header files so imports of imports from them will not break. The exception is core.sys.windows.threadaux because it is imported by core.thread.
n8sh
added a commit
to n8sh/druntime
that referenced
this pull request
Dec 9, 2018
In general avoided removing non-private core.sys.windows.windows imports from other core.sys.windows.* header files so imports of imports from them will not break. The exception is core.sys.windows.threadaux because it is imported by core.thread.
n8sh
added a commit
to n8sh/druntime
that referenced
this pull request
Dec 17, 2018
In general avoided removing non-private core.sys.windows.windows imports from other core.sys.windows.* header files so imports of imports from them will not break. The exception is core.sys.windows.threadaux because it is imported by core.thread.
n8sh
added a commit
to n8sh/druntime
that referenced
this pull request
Dec 17, 2018
n8sh
added a commit
to n8sh/druntime
that referenced
this pull request
Dec 17, 2018
thewilsonator
added a commit
that referenced
this pull request
Dec 18, 2018
Reduce uses of windows.d b/c it's slow (see PR #2336)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing windows.d makes anything importing stdio.d painfully slow.