Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Comments

[WIP] Revamp #1985 - Aa lower lib#2483

Closed
edi33416 wants to merge 2 commits intodlang:masterfrom
edi33416:somzzz_aaLower_lib_rb
Closed

[WIP] Revamp #1985 - Aa lower lib#2483
edi33416 wants to merge 2 commits intodlang:masterfrom
edi33416:somzzz_aaLower_lib_rb

Conversation

@edi33416
Copy link
Contributor

@edi33416 edi33416 commented Feb 4, 2019

This is an attempt to continue @somzzz 's work. Please see #1985 for reference

@dlang-bot dlang-bot added the WIP Work In Progress - not ready for review or pulling label Feb 4, 2019
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @edi33416! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2483"

@edi33416 edi33416 requested a review from ibuclaw February 4, 2019 13:46

/// Determine number of entries in associative array.
extern (C) size_t _aaLen(in AA aa) pure nothrow @nogc
extern (C) size_t _aaLen(in AssocArray!(void, void)* aa) pure nothrow @nogc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps alias AssocArray!(void, void) to AA, to avoid repetition.

@wilzbach
Copy link
Contributor

wilzbach commented Feb 8, 2019

As this wasn't referenced, there's also this previous effort which contains a lot of discussions.

@dlang-bot dlang-bot added Needs Rebase needs a `git rebase` performed Needs Work stalled labels May 27, 2021
@RazvanN7
Copy link
Contributor

RazvanN7 commented Nov 3, 2021

cc @teodutu

@RazvanN7 RazvanN7 closed this Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Needs Rebase needs a `git rebase` performed Needs Work stalled WIP Work In Progress - not ready for review or pulling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants