Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Comments

Fix Issue 19796 - wrong assumption of integral element type#2550

Merged
dlang-bot merged 1 commit intodlang:masterfrom
wilzbach:fix-19796
Apr 9, 2019
Merged

Fix Issue 19796 - wrong assumption of integral element type#2550
dlang-bot merged 1 commit intodlang:masterfrom
wilzbach:fix-19796

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Apr 9, 2019

I didn't know any better way to do this, so better ideas are very welcome!

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Auto-close Bugzilla Severity Description
19796 regression druntime PR#1982 broke array ops on double[] due to wrong assumption of integral element type

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

To target stable perform these two steps:

  1. Rebase your branch to upstream/stable:
git rebase --onto upstream/stable upstream/master
  1. Change the base branch of your PR to stable

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2550"

@dlang-bot dlang-bot added the Bug Fix Include reference to corresponding bugzilla issue label Apr 9, 2019
@wilzbach
Copy link
Contributor Author

wilzbach commented Apr 9, 2019

Regression or critical bug fixes should always target the stable branch.

Regression is in master only.

@dlang-bot dlang-bot merged commit 27a9ac2 into dlang:master Apr 9, 2019
@quickfur
Copy link
Member

quickfur commented Apr 9, 2019

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Bug Fix Include reference to corresponding bugzilla issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants