This repository was archived by the owner on Oct 12, 2022. It is now read-only.
createLowLevelThread: add an optional DLL unload callback#2570
Merged
dlang-bot merged 3 commits intodlang:masterfrom Apr 23, 2019
Merged
createLowLevelThread: add an optional DLL unload callback#2570dlang-bot merged 3 commits intodlang:masterfrom
dlang-bot merged 3 commits intodlang:masterfrom
Conversation
rainers
requested review from
Burgos,
CyberShadow,
MartinNowak,
PetarKirov,
andralex and
wilzbach
as code owners
Contributor
|
Thanks for your pull request, @rainers! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + druntime#2570" |
thewilsonator
approved these changes
Apr 21, 2019
…led if the DLL is supposed to be unloaded
Member
Author
|
Added another special case: do not start thread during DLL_PROCESS_DETACH, it will crash later. |
Contributor
|
Is this good to go? |
Member
Author
I think so. I have rebased #2514 to this and it also passes now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... that is called if the DLL is supposed to be unloaded.
Finally figured a way to deal with the DLL issues in #2514. See comment in the source for explanation: https://github.com/dlang/druntime/compare/master...rainers:dll_thread?expand=1#diff-8bb12ed976acf0a5132e877ec5a01ea8R5696