Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Stop relying on compiler to implicitly add pthread/math libraries#2619

Merged
wilzbach merged 1 commit intodlang:masterfrom
marler8997:explicitLibs
May 30, 2019
Merged

Stop relying on compiler to implicitly add pthread/math libraries#2619
wilzbach merged 1 commit intodlang:masterfrom
marler8997:explicitLibs

Conversation

@marler8997
Copy link
Copy Markdown
Contributor

@marler8997 marler8997 commented May 27, 2019

This is required to be able to remove the hardcoded libraries that druntime/phobos depend on when the option -defaultlib= is given.

Was able to run the unittests with this change and dlang/dmd#9831

This PR is a small piece in working towards a "pay for what you use" model and removing unnecessary interdependency between the compiler and the standard library.

@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request and interest in making D better, @marler8997! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2619"

@wilzbach wilzbach merged commit 21968e8 into dlang:master May 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants