This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Stop relying on compiler to implicitly add pthread/math libraries#2619
Merged
wilzbach merged 1 commit intodlang:masterfrom May 30, 2019
Merged
Stop relying on compiler to implicitly add pthread/math libraries#2619wilzbach merged 1 commit intodlang:masterfrom
wilzbach merged 1 commit intodlang:masterfrom
Conversation
Contributor
|
Thanks for your pull request and interest in making D better, @marler8997! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + druntime#2619" |
wilzbach
approved these changes
May 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required to be able to remove the hardcoded libraries that druntime/phobos depend on when the option
-defaultlib=is given.Was able to run the unittests with this change and dlang/dmd#9831
This PR is a small piece in working towards a "pay for what you use" model and removing unnecessary interdependency between the compiler and the standard library.