Add pthread/math libraries to a couple more rules#2625
Add pthread/math libraries to a couple more rules#2625dlang-bot merged 1 commit intodlang:masterfrom
Conversation
|
Thanks for your pull request and interest in making D better, @marler8997! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + druntime#2625" |
jacob-carlborg
left a comment
There was a problem hiding this comment.
Can’t we aim to remove the makefiles instead of improving the
|
A good goal, but we're likely still a ways away from that. Once we can remove the make files in dmd, then I think we can start looking into that for druntime/photos. In any case, this isn't improving the makefile, it is fixing a rule in the makefile and this fix will also be needed once we move to D. |
|
I thought bug fixes were improvements 😉 |
|
True. Would have been better to say it's not an improvement specific for the makefile. Hopefully dmd can drop the makefiles sooner rather than later. I've been pushing fixes to build.d to get it ready. |
|
They way to get someone to move to a new tool/system/whatever is to stop updating the old system and only update the new. Then eventually there will be enough features or bug fixes that exist in the new system and not the old that the user moves to the new system. In this case this would mean not updating the makefiles and only update the D files. Even if the same bug exists in both. |
|
ready to merge? |
No description provided.