Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Add pthread/math libraries to a couple more rules#2625

Merged
dlang-bot merged 1 commit intodlang:masterfrom
marler8997:moreLibs
Jun 5, 2019
Merged

Add pthread/math libraries to a couple more rules#2625
dlang-bot merged 1 commit intodlang:masterfrom
marler8997:moreLibs

Conversation

@marler8997
Copy link
Copy Markdown
Contributor

No description provided.

@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request and interest in making D better, @marler8997! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2625"

Copy link
Copy Markdown
Contributor

@jacob-carlborg jacob-carlborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can’t we aim to remove the makefiles instead of improving the

@marler8997
Copy link
Copy Markdown
Contributor Author

A good goal, but we're likely still a ways away from that. Once we can remove the make files in dmd, then I think we can start looking into that for druntime/photos.

In any case, this isn't improving the makefile, it is fixing a rule in the makefile and this fix will also be needed once we move to D.

@jacob-carlborg
Copy link
Copy Markdown
Contributor

I thought bug fixes were improvements 😉

@marler8997
Copy link
Copy Markdown
Contributor Author

True. Would have been better to say it's not an improvement specific for the makefile.

Hopefully dmd can drop the makefiles sooner rather than later. I've been pushing fixes to build.d to get it ready.

@jacob-carlborg
Copy link
Copy Markdown
Contributor

They way to get someone to move to a new tool/system/whatever is to stop updating the old system and only update the new. Then eventually there will be enough features or bug fixes that exist in the new system and not the old that the user moves to the new system.

In this case this would mean not updating the makefiles and only update the D files. Even if the same bug exists in both.

@marler8997
Copy link
Copy Markdown
Contributor Author

ready to merge?

@dlang-bot dlang-bot merged commit 0488ba6 into dlang:master Jun 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants