Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Comments

_d_arraysetlengthT should return the new length not the array#2659

Merged
dlang-bot merged 1 commit intodlang:masterfrom
Vild:ArraySetLengthFix
Jul 4, 2019
Merged

_d_arraysetlengthT should return the new length not the array#2659
dlang-bot merged 1 commit intodlang:masterfrom
Vild:ArraySetLengthFix

Conversation

@Vild
Copy link
Contributor

@Vild Vild commented Jul 3, 2019

Needed for: dlang/dmd#10106

_d_arraysetlengthT needs to return the new length of array instead of the array itself.
Without this change the dmd patch will fail on this testcase: https://github.com/dlang/dmd/blob/master/test/compilable/compile1.d#L860

Signed-off-by: Dan Printzell <xwildn00bx@gmail.com>
@Vild Vild requested review from andralex and wilzbach as code owners July 3, 2019 19:08
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @Vild! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2659"

@dlang-bot dlang-bot merged commit 12bcb73 into dlang:master Jul 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants