Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Replace usages of in with const scope#2676

Merged
PetarKirov merged 1 commit intodlang:masterfrom
JinShil:discourage_in
Jul 15, 2019
Merged

Replace usages of in with const scope#2676
PetarKirov merged 1 commit intodlang:masterfrom
JinShil:discourage_in

Conversation

@JinShil
Copy link
Contributor

@JinShil JinShil commented Jul 15, 2019

In support of dlang/dmd#10179

in as a parameter storage class is defined as scope const. However in has not yet
been properly implemented so its current implementation is equivalent to const. Properly
implementing in now will likely break code, so it is recommended to avoid using in, and
explicitly use const or scope const instead, until in is properly implemented.

The use of in as a parameter storage class is already discouraged in the documentation. See https://dlang.org/spec/function.html#parameters

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @JinShil! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2676"

@JinShil
Copy link
Contributor Author

JinShil commented Jul 15, 2019

Mecca failure seems to be unrelated. There may be a runtime mismatch. See dlang-community/mecca#23

@JinShil JinShil changed the title Replace usages of in with const Replace usages of in with const scope Jul 15, 2019
@Geod24
Copy link
Member

Geod24 commented Jul 15, 2019

Uh, Mecca should be fully fixed :/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants