Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Fix printf format in GC config#2988

Closed
Luhrel wants to merge 1 commit intodlang:masterfrom
Luhrel:fix/chkscanf_printf_args
Closed

Fix printf format in GC config#2988
Luhrel wants to merge 1 commit intodlang:masterfrom
Luhrel:fix/chkscanf_printf_args

Conversation

@Luhrel
Copy link
Contributor

@Luhrel Luhrel commented Mar 15, 2020

Blocking dlang/dmd#10920

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @Luhrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + druntime#2988"

@rainers
Copy link
Member

rainers commented Mar 16, 2020

I don't think this change should be necessary. The check should take "default parameter promotion" into consideration, see 6.5.2.2.7: "The ellipsis notation in a function prototype declarator causes
argument type conversion to stop after the last declared parameter. The default argument
promotions are performed on trailing arguments."

The defintion of the term is in 6.5.2.2.6: "If the expression that denotes the called function has a type that does not include a prototype, the integer promotions are performed on each argument, and arguments that have type float are promoted to double. These are called the default argument promotions."

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants