Reduces build scripts code duplication#2998
Conversation
|
Thanks for your pull request and interest in making D better, @denizzzka! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + druntime#2998" |
52118e0 to
b3603f4
Compare
b3603f4 to
0dabe20
Compare
|
A good example of Chesterton's fence. |
|
Can someone tell me an easy way to test Windows builds on Linux?
According to the latest fashion trends (see Meson build system) this is not bad, but good. In any case, this will not be a problem. |
In fact, I am very indignant: duplication here is because someone was too lazy to write a more smart script, not because wildcards isn't supported. Also, in order to develop such a core thing of the language as a runtime library developer actually forced to use Windows. Right now I, probably, violate MS license by downloading Virtualbox image with Windows inside from torrents. Remembering my previous attempts to add changes to Phobos or druntime: about ~90% of errors were on Windows CI checks. If I could I would drop Windows support into an external library to let fans of proprietary OSes support his stuff separately. |
Microsoft provides development images for free. They are only valid for a limited time, but they seem to regularly update the image when the previous one has expired. https://developer.microsoft.com/en-us/windows/downloads/virtual-machines/ |
DMC runs on wine without any issues. |
Christ, as should be absolutely obvious after Mathias' explanation and looking at the CI results, it's not about laziness, but as Mathias clearly stated, the usage of DigitalMars make (and not GNU make) on Windows, at least for the CI boxes... |
|
Fixed in #3026 |
No description provided.