Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Comments

Reduces build scripts code duplication#2998

Closed
denizzzka wants to merge 1 commit intodlang:masterfrom
denizzzka:reduce_duplication
Closed

Reduces build scripts code duplication#2998
denizzzka wants to merge 1 commit intodlang:masterfrom
denizzzka:reduce_duplication

Conversation

@denizzzka
Copy link
Contributor

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @denizzzka! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + druntime#2998"

@denizzzka denizzzka force-pushed the reduce_duplication branch from b3603f4 to 0dabe20 Compare March 19, 2020 11:47
@Geod24
Copy link
Member

Geod24 commented Mar 19, 2020

A good example of Chesterton's fence.
This duplication is in place because DM make does not support wildcard rules.

@denizzzka
Copy link
Contributor Author

Can someone tell me an easy way to test Windows builds on Linux?

This duplication is in place because DM make does not support wildcard rules.

According to the latest fashion trends (see Meson build system) this is not bad, but good. In any case, this will not be a problem.

@denizzzka
Copy link
Contributor Author

This duplication is in place because DM make does not support wildcard rules.

In fact, I am very indignant: duplication here is because someone was too lazy to write a more smart script, not because wildcards isn't supported.

Also, in order to develop such a core thing of the language as a runtime library developer actually forced to use Windows. Right now I, probably, violate MS license by downloading Virtualbox image with Windows inside from torrents.

Remembering my previous attempts to add changes to Phobos or druntime: about ~90% of errors were on Windows CI checks. If I could I would drop Windows support into an external library to let fans of proprietary OSes support his stuff separately.

@ibuclaw
Copy link
Member

ibuclaw commented Mar 20, 2020

Also, in order to develop such a core thing of the language as a runtime library developer actually forced to use Windows. Right now I, probably, violate MS license by downloading Virtualbox image with Windows inside from torrents.

Microsoft provides development images for free. They are only valid for a limited time, but they seem to regularly update the image when the previous one has expired.

https://developer.microsoft.com/en-us/windows/downloads/virtual-machines/

@ibuclaw
Copy link
Member

ibuclaw commented Mar 20, 2020

Can someone tell me an easy way to test Windows builds on Linux?

DMC runs on wine without any issues.

@kinke
Copy link
Contributor

kinke commented Mar 20, 2020

In fact, I am very indignant: duplication here is because someone was too lazy to write a more smart script, not because wildcards isn't supported.

Christ, as should be absolutely obvious after Mathias' explanation and looking at the CI results, it's not about laziness, but as Mathias clearly stated, the usage of DigitalMars make (and not GNU make) on Windows, at least for the CI boxes...

@denizzzka
Copy link
Contributor Author

Fixed in #3026

@denizzzka denizzzka closed this Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants