This repository was archived by the owner on Oct 12, 2022. It is now read-only.
many Standard C declarations are @safe#3005
Closed
WalterBright wants to merge 1 commit intodlang:masterfrom
Closed
many Standard C declarations are @safe#3005WalterBright wants to merge 1 commit intodlang:masterfrom
WalterBright wants to merge 1 commit intodlang:masterfrom
Conversation
Contributor
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + druntime#3005" |
schveiguy
suggested changes
Mar 26, 2020
Member
schveiguy
left a comment
schveiguy
left a comment
There was a problem hiding this comment.
No. A function that is technically safe but not verified by the compiler is the definition of trusted code. If anything, these should be @trusted or @system.
I approve of the @system markings, but reject all the movement of @trusted to @safe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.