Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Fix Issue 20731 - checkaction=context fails for structs with 'alias <slice> this'#3029

Merged
dlang-bot merged 1 commit intodlang:stablefrom
MoonlightSentinel:fix-20731
Apr 13, 2020
Merged

Fix Issue 20731 - checkaction=context fails for structs with 'alias <slice> this'#3029
dlang-bot merged 1 commit intodlang:stablefrom
MoonlightSentinel:fix-20731

Conversation

@MoonlightSentinel
Copy link
Copy Markdown
Contributor

Exclude structs wich are implicitly convertible to a slice due to alias this".

Fix for dlang/dmd#11027

@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20731 normal checkaction=context fails for structs with 'alias this'

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + druntime#3029"

@dlang-bot dlang-bot added the Bug Fix Include reference to corresponding bugzilla issue label Apr 13, 2020
…slice> this'

Exclude structs wich are implicitly convertible to a slice due to `alias this`".
@dlang-bot dlang-bot merged commit ce26f60 into dlang:stable Apr 13, 2020
@MoonlightSentinel MoonlightSentinel deleted the fix-20731 branch April 13, 2020 05:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Bug Fix Include reference to corresponding bugzilla issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants