Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Fix Issue 20750 - checkaction=context segfaults for null references#3045

Merged
dlang-bot merged 1 commit intodlang:stablefrom
MoonlightSentinel:nullToString
Apr 19, 2020
Merged

Fix Issue 20750 - checkaction=context segfaults for null references#3045
dlang-bot merged 1 commit intodlang:stablefrom
MoonlightSentinel:nullToString

Conversation

@MoonlightSentinel
Copy link
Copy Markdown
Contributor

No description provided.

@dlang-bot
Copy link
Copy Markdown
Contributor

dlang-bot commented Apr 19, 2020

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20750 minor checkaction=context segfaults for null references

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + druntime#3045"

@dlang-bot dlang-bot added the Bug Fix Include reference to corresponding bugzilla issue label Apr 19, 2020
@Geod24
Copy link
Copy Markdown
Member

Geod24 commented Apr 19, 2020

I can see this creating some bloat, though. But at the same time, trying to reduce the bloat will lead to issues with attributes.

@MoonlightSentinel MoonlightSentinel changed the base branch from master to stable April 19, 2020 12:08
@MoonlightSentinel
Copy link
Copy Markdown
Contributor Author

MoonlightSentinel commented Apr 19, 2020

Should this be inlined instead of an additional function?

EDIT: Amended to move the check inside of miniFormat

@MoonlightSentinel
Copy link
Copy Markdown
Contributor Author

Sqashed the inline changes into the first commit.

@dlang-bot dlang-bot merged commit b6f45c8 into dlang:stable Apr 19, 2020
@MoonlightSentinel MoonlightSentinel deleted the nullToString branch April 19, 2020 13:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Bug Fix Include reference to corresponding bugzilla issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants