Fix Issue 21110 - OOB memory access, safety violation#3267
Fix Issue 21110 - OOB memory access, safety violation#3267dlang-bot merged 1 commit intodlang:stablefrom
Conversation
|
Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + druntime#3267" |
thewilsonator
left a comment
There was a problem hiding this comment.
Please target stable
d7b9182 to
cf381e1
Compare
cf381e1 to
c3cf360
Compare
|
Test seems to be failing on all platforms |
416940d to
4ca598b
Compare
|
@Geod24 @thewilsonator This seems to be green now. Could you please take another look? |
|
This still targets master. |
|
It'a an old regression. Since 2.065. |
|
Of course now we have spurious error messages :(( |
It seems that this PR [1] forgot to add checks for OOB accesses.
I had to modify_d_assert_failto be able to put a nice error message.[1] #1891