Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

benchmark: add __MANGLED_FUNCTION__ special keyword to the lexer and parser#3387

Closed
ljmf00 wants to merge 1 commit intodlang:masterfrom
ljmf00:rewrite-demangle
Closed

benchmark: add __MANGLED_FUNCTION__ special keyword to the lexer and parser#3387
ljmf00 wants to merge 1 commit intodlang:masterfrom
ljmf00:rewrite-demangle

Conversation

@ljmf00
Copy link
Member

@ljmf00 ljmf00 commented Mar 5, 2021

Signed-off-by: Luís Ferreira contact@lsferreira.net


CC: @maxhaton
Related to dlang/dmd#12252.

…d parser

Signed-off-by: Luís Ferreira <contact@lsferreira.net>
@ljmf00 ljmf00 requested review from andralex and wilzbach as code owners March 5, 2021 20:08
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @ljmf00! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + druntime#3387"

@RazvanN7
Copy link
Contributor

@ljmf00 This seems to be stalled on dlang/dmd#12252 which is also stalled. How do we proceed here?

@dlang-bot dlang-bot removed the stalled label Aug 12, 2021
@ljmf00
Copy link
Member Author

ljmf00 commented Aug 17, 2021

@ljmf00 This seems to be stalled on dlang/dmd#12252 which is also stalled. How do we proceed here?

I think this is not to be implemented in favour of the trait described during the discussion of the referred PR. I will try to revive the trait implementation from the ghost user.

@ljmf00 ljmf00 closed this Aug 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants