Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Comments

Make move -dip1000 compatible#3510

Merged
dlang-bot merged 1 commit intodlang:masterfrom
dkorpel:move-dip1000
Jul 8, 2021
Merged

Make move -dip1000 compatible#3510
dlang-bot merged 1 commit intodlang:masterfrom
dkorpel:move-dip1000

Conversation

@dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Jul 6, 2021

Continuation of #3480

It was mentioned in the discussion that the two-argument move(source, target) is not compatible because dip1000 wants the target to be the first parameter. However, the fixes for the single parameter variant were also incomplete in that PR. This adds the missing scope and return.

@dkorpel dkorpel requested review from andralex and wilzbach as code owners July 6, 2021 19:23
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + druntime#3510"

@ibuclaw ibuclaw closed this Jul 6, 2021
@ibuclaw ibuclaw reopened this Jul 6, 2021
@ibuclaw ibuclaw closed this Jul 6, 2021
@ibuclaw ibuclaw reopened this Jul 6, 2021
@dlang-bot dlang-bot merged commit 457e7ee into dlang:master Jul 8, 2021
@dkorpel dkorpel deleted the move-dip1000 branch July 8, 2021 08:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants