Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Comments

core.checkedint.addu: Faster (like subu: only one compare-and-branch) (resubmit).#3513

Merged
RazvanN7 merged 1 commit intodlang:masterfrom
DoctorNoobingstoneIPresume:210614_core_checkedint_addu_07h
Aug 6, 2021
Merged

core.checkedint.addu: Faster (like subu: only one compare-and-branch) (resubmit).#3513
RazvanN7 merged 1 commit intodlang:masterfrom
DoctorNoobingstoneIPresume:210614_core_checkedint_addu_07h

Conversation

@DoctorNoobingstoneIPresume

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @DoctorNoobingstoneIPresume! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + druntime#3513"

Copy link
Member

@ibuclaw ibuclaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point, I'm not sure the druntime pipelines can be trusted.

@DoctorNoobingstoneIPresume
Copy link
Author

DoctorNoobingstoneIPresume commented Jul 13, 2021

At this point, I'm not sure the druntime pipelines can be trusted.

"So I have heard.", @DoctorNoobingstoneIPresume typed with a hypocrite grin from his Windows 98^H^HXP computer. :'(

Copy link
Author

@DoctorNoobingstoneIPresume DoctorNoobingstoneIPresume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check warning on line 173 in src/core/checkedint.d
Codecov / codecov/patch
src/core/checkedint.d#L171-L173
Added lines #L171 - L173 were not covered by tests

But it appears to me that these lines of code are actually covered by unittests.

@RazvanN7
Copy link
Contributor

@ibuclaw Any second thoughts on this?

@RazvanN7
Copy link
Contributor

RazvanN7 commented Aug 4, 2021

@ibuclaw Should this be closed or can we merge it?

@RazvanN7 RazvanN7 merged commit d42e1a3 into dlang:master Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants