Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Comments

TypeInfo_Class: Make 2 superfluously virtual functions final#3544

Merged
dlang-bot merged 1 commit intodlang:masterfrom
kinke:classinfo_virtuals
Aug 16, 2021
Merged

TypeInfo_Class: Make 2 superfluously virtual functions final#3544
dlang-bot merged 1 commit intodlang:masterfrom
kinke:classinfo_virtuals

Conversation

@kinke
Copy link
Contributor

@kinke kinke commented Aug 16, 2021

No idea what they are good for anyway; the info might be handy due to TypeInfo_Interface having a TypeInfo_Class info field.

No idea what they are good for anyway; the `info` might be handy
due to `TypeInfo_Interface` having a `TypeInfo_Class info` field.
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + druntime#3544"

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants